This repository was archived by the owner on Sep 4, 2025. It is now read-only.
When unmarshaling, check the payload's type even if no ID is included#125
Open
CrushedPixel wants to merge 1 commit intogoogle:masterfrom
Open
When unmarshaling, check the payload's type even if no ID is included#125CrushedPixel wants to merge 1 commit intogoogle:masterfrom
CrushedPixel wants to merge 1 commit intogoogle:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Contributor
Author
|
Signed it. |
|
CLAs look good, thanks! |
|
Any update on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of now,
request.unmarshalNodeonly checks the payload'stypefield if theidfield is set. This doesn't make sense when unmarshalling aPOSTpayload, as per jsonapi spec the client is not required to set anid, but is required to set the correcttypefor the resource they're creating.This PR addresses this issue by simply moving the type check before the check for an empty
idfield.